ngless-toolkit / ngless

NGLess: NGS with less work
https://ngless.embl.de
Other
142 stars 24 forks source link

ENH+TST Expand subfeatures when counting with a GFF file #66

Closed unode closed 6 years ago

unode commented 6 years ago

Using a GFF containing "gene_name=nameA,nameB" would result in:

nameA,nameB    1

Now the same results in:

nameA    1
nameB    1

This follows after https://git.io/vpagq and the case of:

Parent=AF2312,AB2812,abc-3
unode commented 6 years ago

Seems like we need to reactivate Travis. The move of the repository likely broke this.

luispedro commented 6 years ago

I re-authorized travis, so it works again.

(It also kept the history of the previous builds, which is cool, especially as the builds now print out a benchmark at the very end, so we can compare performance over time).

luispedro commented 6 years ago

The code looks good (I mean, this part of the code is very hairy because we are trying to handle so many variants at once that I don't see a way to do it very cleanly).

If the tests pass on your side, we can merge (and that will trigger the travis re-build, I think).