nglviewer / ngl

WebGL protein viewer
http://nglviewer.org/ngl/
MIT License
657 stars 168 forks source link

#865 upgrade three js legacy lights #1037

Closed ppillot closed 1 month ago

ppillot commented 2 months ago

This PR upgrades the Three.js dependency to a more recent version, which still supports the legacy color management. It derives from the #1002 PR which was attempting at migrating the internal color management to a complete linear workflow.

As the current version of Three.js in the codebase raises (unjustified) alerts from npm audit and other dependency alert bots, this intermediary upgrade is somehow necessary.

The standard library dev dependency has been upgraded as well as 'Jest'. standard is seldom used at the moment, as it does not lint ts files.

Known issues

fredludlow commented 2 months ago

This is a massive amount of work - thank you!

I have tried every demo etc and I can't spot regressions between here and master. I did notice some other uncaught regressions that slipped in somewhere earlier - have created a separate issue for those.