Closed ppillot closed 1 month ago
This is a massive amount of work - thank you!
I have tried every demo etc and I can't spot regressions between here and master. I did notice some other uncaught regressions that slipped in somewhere earlier - have created a separate issue for those.
This PR upgrades the Three.js dependency to a more recent version, which still supports the legacy color management. It derives from the #1002 PR which was attempting at migrating the internal color management to a complete linear workflow.
As the current version of Three.js in the codebase raises (unjustified) alerts from npm audit and other dependency alert bots, this intermediary upgrade is somehow necessary.
The
standard
library dev dependency has been upgraded as well as 'Jest'.standard
is seldom used at the moment, as it does not lint ts files.Known issues
ambientIntensity
) and directional lighting (lightIntensity
) have been increased to mimic the previous rendering (respectively 0.2 --> 0.3, 1 --> 1.2). This means that users who have custom lighting presets will have to tweak them after the update.standard
. This is because the linter does not find any js file in the src directory. I've commented-out the linting commands for now.