nglviewer / ngl

WebGL protein viewer
http://nglviewer.org/ngl/
MIT License
667 stars 170 forks source link

default orientation makes the molecule small #189

Closed hainm closed 6 years ago

hainm commented 8 years ago

I am using ngl dev just pulled one or two days ago.

screenshot

arose commented 8 years ago

what about the current version?

hainm commented 8 years ago

same thing

commit aa8d8e5c7f9f41a35cd710c464a61b16c3de71c5
Author: arose <alexander.rose@weirdbyte.de>
Date:   Thu Aug 18 20:03:53 2016 -0700

    limit travis to current major node version
arose commented 8 years ago

have you updated the build?

hainm commented 8 years ago

tricky question. no, I haved not because you always did that. :D

arose commented 8 years ago

Please build it. I recently made some changes on how to do that, see https://github.com/arose/ngl/blob/master/DEVELOPMENT.md

hainm commented 8 years ago

The necessary dependencies can be installed with npm install

is there any way to install all the packages in a single command? I keep getting missing some.

hainm commented 8 years ago

for example, getting

Cannot find module 'rollup-plugin-istanbul'

arose commented 8 years ago

did you do npm install?

hainm commented 8 years ago

I tried

npm run-script build

saw missing rollup, so keep going

npm install rollup -g

and so on. :D

arose commented 8 years ago

inside the ngl repository directory do npm install then npm run-script build

hainm commented 8 years ago

thanks. I clearly that I misunderstood the doc.

btw, I updated ngl.js but still getting small molecule.

arose commented 8 years ago

build/ngl.js (npm run-script build) or dist/ngl.js (npm run-script build-min)?

hainm commented 8 years ago

The min version from

npm run-script build-min

arose commented 8 years ago

still an issue?

hainm commented 8 years ago

I am not sure if I got the cache issue, but still see the small molecule.

hainm commented 8 years ago

I confirm that the issue is not solved yet.

arose commented 8 years ago

I think this is just how it currently works. The zoom is such that however you rotate the structure it won't get clip at the edges (there are some edge cases where this still happens).

Initial view screenshot 31

Rotated, alomost touching the edges screenshot 32

arose commented 8 years ago

A new feature could be a zoom that is optimized for the current orientation.