search

nglviewer / ngl

WebGL protein viewer
http://nglviewer.org/ngl/
MIT License
664 stars 169 forks source link

Update type of BondData#picking to the more correct BondPicker #907

Closed luxaritas closed 2 years ago

luxaritas commented 2 years ago

This parameter is always set as a BondPicker, so I've typed it accordingly in order to make the relevant methods available

fredludlow commented 2 years ago

Thanks @luxaritas for this - this allows a few other things to be simplified (I pushed a new commit to your branch) - could you sanity check those for me and I'll merge it. I've tested it merged into master locally as well and it's fine with new TS

fredludlow commented 2 years ago

Thanks @luxaritas for this - this allows a few other things to be simplified (I pushed a new commit to your branch) - could you sanity check those for me and I'll merge it. I've tested it merged into master locally as well and it's fine with new TS

luxaritas commented 2 years ago

The as any in bondData.picking = new BondPicker(...) as any is no longer needed now, right? Otherwise, looks reasonable