nglviewer / nglview

Jupyter widget to interactively view molecular structures and trajectories
http://nglviewer.org/nglview/latest/
Other
816 stars 133 forks source link

Update widget.py: fix html icon display none #1072

Closed wangm23456 closed 1 year ago

wangm23456 commented 1 year ago

Fix the problem that the icons does not display in html.

> python -c 'import nglview; print(nglview.__version__)'
3.0.6
> python -c 'import ipywidgets; print(ipywidgets.__version__)'
8.1.0
hainm commented 1 year ago

@wangm23456 thanks for the fix. Can you please post the screenshot of the broken one?

wangm23456 commented 1 year ago

@wangm23456 thanks for the fix. Can you please post the screenshot of the broken one? 感谢您的修复。可以发一下损坏的截图吗?

image

I found some issues regarding this in jupyter-widgets, but I am unsure how to solve them using jupyter.

https://github.com/jupyter-widgets/ipywidgets/issues/3658#issue-1509801663 https://github.com/jupyter-widgets/ipywidgets/issues/3623#issue-1424156617 https://github.com/jupyter-widgets/ipywidgets/issues/3000#issue-729675072

hainm commented 1 year ago

Thanks @wangm23456 very much.

hainm commented 1 year ago

published pypi package:

image

will be available in conda soon.