nglviewer / nglview

Jupyter widget to interactively view molecular structures and trajectories

http://nglviewer.org/nglview/latest/

Other

788 stars 132 forks source link

Make moving making work again #1103

Closed hai-schrodinger closed 4 months ago

hai-schrodinger commented 4 months ago

1102

Long story short: I accidentally used _handle_custom_msg method name that overwrites https://github.com/jupyter-widgets/ipywidgets/blob/b78de43e12ff26e4aa16e6e4c6844a7c82a8ee1c/python/ipywidgets/ipywidgets/widgets/widget.py#L788

The view. on_msg(self. _handle_custom_msg) has never worked due to the wrong signature. This failure blocks on_msg function execution in https://github.com/nglviewer/nglview/blob/98d7df9c5b2c035278724eacfb8184631c17015b/nglview/contrib/movie.py#L226

The view._handle_custom_msg, however, is still be executed in different code branch: https://github.com/jupyter-widgets/ipywidgets/blob/b78de43e12ff26e4aa16e6e4c6844a7c82a8ee1c/python/ipywidgets/ipywidgets/widgets/widget.py#L761-L782