search

nglviewer / nglview

Jupyter widget to interactively view molecular structures and trajectories
http://nglviewer.org/nglview/latest/
Other
823 stars 134 forks source link

nglview 3.1 not working with nbclassic 1.0 #1106

Closed linuxrider closed 20 hours ago

linuxrider commented 7 months ago

I found that nglview does not work with nbclassic 1.0. It failed to load ColormakerRegistryModel from module nglview-js-widgets when importing the library. Furthermore, with nglview.demo() it could not load NGLModel. With jupyterlab it works without problems, however. I tested it with Firefox and Chromium with the same result for both. I think a similar issue was reported with vscode #1085.

Here the screenshots for the different environments micromamba create -n nglview jupyterlab=4.1.5 nbclassic=1.0 nglview=3.0.8 nbclassic nbclassic 1.0, nglview 3.0.8

micromamba create -n nglview jupyterlab=4.1.5 nbclassic=1.0 nglview=3.1.2 jupyterlab jupyterlab 4.1.5, nglview 3.1.2 nbclassic nbclassic 1.0, nglview 3.1.2

hainm commented 7 months ago

hi @linuxrider, thanks for your report.

hainm commented 1 day ago

Please try latest version, v3.1.4 pip3 install nglview==3.1.4 (conda version will be released later via conda-forge)

linuxrider commented 1 day ago

Tried it and it seems to work now with nbclassic 1.1.0. Thanks.