Open rafaelss95 opened 3 years ago
Seems reasonable to me. You're welcome to submit a PR.
Hey, do you have any direction to point up? I mean, where should I add such option?
I was thinking of having an InjectionToken
like BIND_QUERY_PARAMS_CONFIG
with a config that contains a flag like ignoreInvalidForm
, which is false
by default (btw, these names are just thoughts), but I don't know if there's a better option. I'll wait your contact before start working on this.
I think we should allow it in the following cases:
I'm submitting a...
Current behavior
AFAIK there's no way to prevent the change of query params when a form is invalid.
Expected behavior
I'd like to have an option to prevent the change of query params when a
FormGroup
is invalid.Minimal reproduction of the problem with instructions
https://stackblitz.com/edit/angular-ewwssg-nwxzlt
This use case is with date, but I have other cases where I have a masked input and this is also problematic.
What is the motivation / use case for changing the behavior?
I have two datepicker inputs that represent a range that an user can select. As a business rule, the start date can't be greater than the end date, but as I use
updateOn: submit
(the filter has a submit button) I don't have a way to do this check before the user submits the form. It would be nice then to have an option to not change the query params until the form is valid.Environment