Closed va-stefanek closed 11 months ago
Run & review this pull request in StackBlitz Codeflow.
@NetanelBasal do you have any idea how I can write tests for it? I see that we are not testing dialogRef methods like onClose, onReset and now mine updateDialogConfig
You can mock it
@NetanelBasal I have added some basic test and documentation
@NetanelBasal can I ask for review?
We appreciate the PR, I've added this feature (with a different API) as part of a refactor I've made.
It's available in v4.2.0, see the usage example under DialogRef
API
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
We are not allowed to override config once it has been opened
Issue Number: #41
What is the new behavior?
We can override config of the dialog after opening