Currently, for the "object syntax", all (both) keys are required because that seemed reasonable to me.
the other option would have been to make them default to true, like the old enableClose does.
let me know what you think!
I haven't adjusted the tests yet because I've never done any testing with angular / jasmine / ...
I'd imagine we want a kind of matrix test on top of the existing ones.
I'll try to look into that, but feel free comment on the feature/code change already - no need to think about tests if this is not an implementation you would merge :b
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The config option
enableClose
applies to both closing using the escape key and clicking on the backdropIssue Number: #34
What is the new behavior?
This allows you to only close the dialog on escape press but not backdrop click, or vice versa.
This implementation is backwards compatible, old values are treated just like before.
Does this PR introduce a breaking change?
Other information
Currently, for the "object syntax", all (both) keys are required because that seemed reasonable to me. the other option would have been to make them default to true, like the old enableClose does. let me know what you think!
I haven't adjusted the tests yet because I've never done any testing with angular / jasmine / ... I'd imagine we want a kind of matrix test on top of the existing ones.
I'll try to look into that, but feel free comment on the feature/code change already - no need to think about tests if this is not an implementation you would merge :b
closes #34