fix: crypto does not work in http domain (specs)

nuriddin2468 commented 6 months ago

Removing crypto package for generating uuid

What kind of change does this PR introduce?

Generating uuid now works without "crypto" package.

[x ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

While domain is working under HTTP , crypto does not exist, so it throws an error randomUUID function not found.

Source: click

Issue Number: N/A

What is the new behavior?

Now it generated uuid without crypto, so in HTTP domain it works fine

Does this PR introduce a breaking change?

[ ] Yes
[x] No

stackblitz[bot] commented 6 months ago

Run & review this pull request in StackBlitz Codeflow.

nuriddin2468 commented 5 months ago

@NetanelBasal up pls.

NetanelBasal commented 3 months ago

I don't see any reason to work with HTTP. I'm willing to merge a PR that accepts a custom function to generate the id, but we don't need this code in our bundle :)

nuriddin2468 commented 2 months ago

During the development phase, we encountered challenges when testing certain features due to the necessity of using private endpoints. Unfortunately, this incompatibility led to disruptions in most of the library's dialog functionalities related to cryptographic specifications. But , we have already transitioned to our self-made workaround. I can close merge request if there is no need to this fix.

ngneat / dialog