Closed jacobg213 closed 3 months ago
Please check if your PR fulfills the following requirements:
What kind of change does this PR introduce?
[x] Bugfix [ ] Feature [ ] Code style update (formatting, local variables) [ ] Refactoring (no functional changes, no api changes) [ ] Build related changes [ ] CI related changes [ ] Documentation content changes [ ] Other... Please describe:
Issue #81 is reintroduced when upgrading to TS 5.4+.
Issue Number: #119
The updated typing allows the same behavior we expect today on TS versions below 5.4.
[ ] Yes [x] No
Angular 18 requires TS 5.4+ which breaks the NonNullable type.
This PR replaces NonNullable with Exclude to allow correct typing of ExtractRefProp and fix the issue where opening dialogs containing undefined values throws TS2769 when trying to set the data property.
Run & review this pull request in StackBlitz Codeflow.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue #81 is reintroduced when upgrading to TS 5.4+.
Issue Number: #119
What is the new behavior?
The updated typing allows the same behavior we expect today on TS versions below 5.4.
Does this PR introduce a breaking change?
Other information
Angular 18 requires TS 5.4+ which breaks the NonNullable type.
This PR replaces NonNullable with Exclude to allow correct typing of ExtractRefProp and fix the issue where opening dialogs containing undefined values throws TS2769 when trying to set the data property.