ngneat / dialog

👻 A simple to use, highly customizable, and powerful modal for Angular Applications
https://ngneat.github.io/dialog/
MIT License
394 stars 38 forks source link

Add ARIA role specifier to dialogs #90

Closed milo526 closed 1 year ago

milo526 commented 1 year ago

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[x] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior

There is no ARIA role specified on the modals

Expected behavior

Modals have an role="dialog" attribute.

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

ARIA specifies that modals should have a role="dialog" attribute which indicates to accessibility software that a certain element should be considered as a dialog. This changes the functionality of, amongst others, screen readers.

See: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/dialog_role

Environment


Angular version: X.Y.Z


Browser:
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX

For Tooling issues:
- Node version: XX  
- Platform:  

Others: