feat: add aria role attribute to dialog component - Githubissues

ngneat / dialog

👻 A simple to use, highly customizable, and powerful modal for Angular Applications

https://ngneat.github.io/dialog/

MIT License

394 stars 38 forks source link

feat: add aria role attribute to dialog component #91

Closed milo526 closed 1 year ago

milo526 commented 1 year ago

Fixes #90

PR Checklist

Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: CONTRIBUTING.md#commit
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #90

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

stackblitz[bot] commented 1 year ago

Run & review this pull request in StackBlitz Codeflow.