feat(effects-ng): 🔥 change effects interface - Githubissues

ngneat / effects

🪄 A framework-agnostic RxJS effects implementation

https://www.netbasal.com

MIT License

63 stars 11 forks source link

feat(effects-ng): 🔥 change effects interface #20

Closed yackinn closed 2 years ago

yackinn commented 2 years ago

account for interchangeable action stream inside effects manager

BREAKING CHANGE: 🧨 Effects interface change

PR Checklist

Please check if your PR fulfills the following requirements:

[ ] The commit message follows our guidelines: https://github.com/ngneat/effects/blob/master/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

yackinn commented 2 years ago

The factory won't be called on effect creation. It's rather called when the effect is being subscribed to in the effects manager. It will open the possibility to swap out the actions stream for a custom stream.