Which @ngneat/effects-* package(s) are the source of the bug?
effects
Is this a regression?
No
Description
When you call the initEffects with {dispatchByDefault: true}, you no longer have the option not to dispatch an action from an effect. This is the piece of code that causes the issue:
// effects-manager.ts
if (
effect.config?.dispatch || // <-- should be ??
(this.config.dispatchByDefault && checkAction(maybeAction))
) {
actions.dispatch(maybeAction);
}
I've prepared a fix and new test that covers this case, but I'd like #23 to be merged before I open a PR for this issue, if you don't mind.
Please provide a link to a minimal reproduction of the bug
No response
Please provide the exception or error you saw
No response
Please provide the environment you discovered this bug in
Which @ngneat/effects-* package(s) are the source of the bug?
effects
Is this a regression?
No
Description
When you call the
initEffects
with{dispatchByDefault: true}
, you no longer have the option not to dispatch an action from an effect. This is the piece of code that causes the issue:I've prepared a fix and new test that covers this case, but I'd like #23 to be merged before I open a PR for this issue, if you don't mind.
Please provide a link to a minimal reproduction of the bug
No response
Please provide the exception or error you saw
No response
Please provide the environment you discovered this bug in
No response
Anything else?
No response
Do you want to create a pull request?
Yes