ngneat / effects

🪄 A framework-agnostic RxJS effects implementation
https://www.netbasal.com
MIT License
63 stars 11 forks source link

tapResult added console error if no error handling was specified #33

Closed feitzi closed 2 years ago

feitzi commented 2 years ago

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

If you don't explicitly specify an error handler in tabResult, you don't get any information that something didn't work. This is very misleading.

What is the new behavior?

TabResult has now a default console.error handling in case no custom error handler is specified

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information