Closed EricPoul closed 1 year ago
Run & review this pull request in StackBlitz Codeflow.
@NetanelBasal when we agree on everything I'll update docs.
Also, I gave up implementing component effects since we don't have a hook while the component injector creating, like ENVIRONMENT_INITIALIZER
to trigger it to subscribe on all effects
under the hood.
@EricPoul, thanks for the PR. It'll be helpful if you can summarize the changes before I review them.
I added info to the What is the new behavior?
block. Or I can give more explicit info.
Yes, it's fine, I've missed it.
Also, I gave up implementing component effects since we don't have a hook while the component injector creating.
We can leverage the hostDirectives features, but I'm wondering if it'll be "to abuse it".
We can leverage the hostDirectives features, but I'm wondering if it'll be "to abuse it".
It might work. I'll give it a try separately from this pr.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
dispatch
multiple actions per one call.dispatch
method andcreateEffect
function are now strictly typed.toProps
and madetoPayload
work only withpayload
s.effects
in Angular:provideEffectsManager(config?)
in the root.provideEffects(EffectOne, EffectTwo)
in any environment providers.Does this PR introduce a breaking change?
Other information