ngneat / effects

🪄 A framework-agnostic RxJS effects implementation
https://www.netbasal.com
MIT License
63 stars 11 forks source link

feat(effects): remove one overload from create-effect function #40

Closed EricPoul closed 1 year ago

EricPoul commented 1 year ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

stackblitz[bot] commented 1 year ago

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

EricPoul commented 1 year ago

I removed one overload from createEffect to allow to return of both Action and an array of Action in one effect to dispatch them.

EricPoul commented 1 year ago

Could you bump this release? @NetanelBasal

NetanelBasal commented 1 year ago

done