ngneat / effects

🪄 A framework-agnostic RxJS effects implementation
https://www.netbasal.com
MIT License
63 stars 11 forks source link

fix(effects-ng): rework of directive effects #56

Closed EricPoul closed 1 year ago

EricPoul commented 1 year ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: https://github.com/ngneat/effects/issues/55

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

stackblitz[bot] commented 1 year ago

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

NetanelBasal commented 1 year ago

@EricPoul can you please migrate to standalone? It should be automatically using https://angular.io/guide/standalone-migration. You can do it with the Nx plugin in vscode. You need to run three migration commands.