ngneat / effects

🪄 A framework-agnostic RxJS effects implementation
https://www.netbasal.com
MIT License
63 stars 11 forks source link

fix(effects-ng): properly manage multiple effects with same class and function names #61

Closed EricPoul closed 1 year ago

EricPoul commented 1 year ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: https://github.com/ngneat/effects/issues/60

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

stackblitz[bot] commented 1 year ago

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

EricPoul commented 1 year ago

@NetanelBasal, I change the logic a little. Now I check prototypes of the instances to verify if instances are created by the same class or just instances share the same class name.