ngneat / effects

🪄 A framework-agnostic RxJS effects implementation
https://www.netbasal.com
MIT License
63 stars 11 forks source link

feat(effects): export involved ts-action types #65

Open Char2sGu opened 1 year ago

Char2sGu commented 1 year ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Currently, we're using some functions from ts-action, but the types involved by these functions are not exposed if the user only installed "@ngneat/effects".

It might be ok for simple use cases, but when the user want to create some utility functions upon this library, it could be a little troublesome, as the user would have to include a whole library "ts-action" in order to have access to a few types to annotate their utility functions.

Besides, if the user choose to install "ts-action" to have access to these types, it can be also a little confusing when it comes to IDE auto-imports, because there could be multiple suggestions for the same function, e.g. props.

Issue Number: N/A

What is the new behavior?

All the involved types are re-exported from "ts-action".

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

stackblitz[bot] commented 1 year ago

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.