ngneat / elf

🧙‍♀️ A Reactive Store with Magical Powers
https://ngneat.github.io/elf/
MIT License
1.62k stars 93 forks source link

Added a function for tracking request result on additional keys, after successful fetch… #456

Closed WillooWisp closed 1 year ago

WillooWisp commented 1 year ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Possible to use new method for tracking request result on additional keys.

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

stackblitz[bot] commented 1 year ago

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

NetanelBasal commented 1 year ago

Let's update the docs

NetanelBasal commented 1 year ago

One last thing, your commits are not based on our guidelines. Please squash your commits and use npm run c

WillooWisp commented 1 year ago

@NetanelBasal Squashed commits and npm run c used to create proper commit.

NetanelBasal commented 1 year ago

Tests failed

WillooWisp commented 1 year ago

Tests failed

@NetanelBasal should be fixed now.

WillooWisp commented 1 year ago

@NetanelBasal anything else stopping the PR acceptance? When can we expect a release including this?