fix: do not debounce for update on blur - Githubissues

ngneat / forms-manager

🦄 The Foundation for Proper Form Management in Angular

https://www.netbasal.com

MIT License

518 stars 29 forks source link

fix: do not debounce for update on blur #18

Closed alexcotelin closed 4 years ago

alexcotelin commented 4 years ago

PR Checklist

Please check if your PR fulfills the following requirements:

[ ] The commit message follows our guidelines: https://github.com/ngneat/forms-manager/blob/master/CONTRIBUTING.md#commit
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #17

What is the new behavior?

The debounce only applies for FormControls that do not have updateOn:'blur'

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

alexcotelin commented 4 years ago

Hey @NetanelBasal, can you please have a look at the implementation before I start adding unit tests? I've update the stackblitz example to reflect the changes