ngneat / forms-manager

🦄 The Foundation for Proper Form Management in Angular
https://www.netbasal.com
MIT License
518 stars 29 forks source link

feat(lib): allow to add custom storage #28

Open va-stefanek opened 3 years ago

va-stefanek commented 3 years ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Currently we can only use localStorage as a persistence storage

Issue Number: #6

What is the new behavior?

We can use any persistence storage which extends proper interface

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

NetanelBasal commented 3 years ago

Thanks for the PR. Can you update the docs, please?

va-stefanek commented 3 years ago

@NetanelBasal Done.

AdmilsonCossa commented 3 years ago

Any updates on this feature? This is very important!

va-stefanek commented 3 years ago

@AdmilsonCossa I will try to complete this by the end of the week.

hiepxanh commented 3 years ago

@va-stefanek looking for your update sir :D

va-stefanek commented 2 years ago

@NetanelBasal let me know if we are still interested in that feature, whether we should remove FORMS_MANAGER_SESSION_STORAGE_PROVIDER. I have pushed new changes with using @ngneat/storage

Sorry everyone for the delay.

hiepxanh commented 2 years ago

ya I'm looking for this feature still waiting :D

NetanelBasal commented 2 years ago

@va-stefanek sure