fix: do not use spread operator on valid dates - Githubissues

ngneat / forms-manager

🦄 The Foundation for Proper Form Management in Angular

https://www.netbasal.com

MIT License

519 stars 29 forks source link

fix: do not use spread operator on valid dates #8

Closed dspeirs7 closed 4 years ago

dspeirs7 commented 4 years ago

To ensure that isObject does not return true for dates to avoid using the spread operator on a date causing it to be an empty object.

PR Close #7

PR Checklist

Please check if your PR fulfills the following requirements:

[X] The commit message follows our guidelines: https://github.com/ngneat/forms-manager/blob/master/CONTRIBUTING.md#commit
[X] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

(https://github.com/ngneat/forms-manager/issues/7)

Issue Number:7

What is the new behavior?

A date value is not cloned using the spread operator leaving it as an empty object.

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

NetanelBasal commented 4 years ago

Please add yourself to the contributors. npm run contributors:add