ngneat / helipopper

🚁 A Powerful Tooltip and Popover for Angular Applications
https://ngneat.github.io/helipopper/
MIT License
405 stars 41 forks source link

Variations for lazy loaded modules #136

Closed OrShalmayev closed 11 months ago

OrShalmayev commented 1 year ago

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request
[x ] Other... Please describe:

Current behavior

The tooltip variations provided in the root module are not accessible via lazy loaded modules.

Expected behavior

The tooltip variations provided in the root module should be accessible from lazy loaded modules.

Minimal reproduction of the problem with instructions

Create a root module in an Angular application that includes tooltip variations. Create a lazy loaded module in the same application. Attempt to access the tooltip variations from the lazy loaded module. Notice that the tooltip variations are not accessible.

What is the motivation / use case for changing the behavior?

The motivation for changing this behavior is to enable lazy loaded modules to utilize the tooltip variations provided in the root module. This would improve code organization and reusability, allowing developers to define tooltip variations once and use them throughout the application.

Environment


Angular version: 15


Browser:
- [ x] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX

For Tooling issues:
- Node version: 18  
- Platform:  mac

Others:

shaharkazaz commented 1 year ago

This doesn't sound right, can you please share a Stackblitz reproduction of your case? Also, what version are you working with?

NetanelBasal commented 11 months ago

You should provide it in boostrapApplication