ngneat / helipopper

🚁 A Powerful Tooltip and Popover for Angular Applications
https://ngneat.github.io/helipopper/
MIT License
405 stars 41 forks source link

fix: updating tp content from empty to value doesn't create the tp instance #139

Open MichalK6677 opened 1 year ago

MichalK6677 commented 1 year ago

fix: updating tp content from empty to value doesn't create the tp instance)

Fixes #138

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

138

What is the new behavior?

The solution here is to create/destroy the instance depending on the content changes as well and not just on initialization.

Does this PR introduce a breaking change?

[ ] Yes
[x ] No

Other information

stackblitz[bot] commented 1 year ago

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.