ngneat / overview

🤖 A collection of tools to make your Angular views more modular, scalable, and maintainable
MIT License
121 stars 7 forks source link

@ngneat/overview crashes app when updated to version 3.0.0 #10

Open st-clair-clarke opened 3 years ago

st-clair-clarke commented 3 years ago

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior

upgrading from @ngneat/overview 2.1 - 3.x.x results in the following error

Uncaught Error: Type HotToastModule does not have 'ɵmod' property. at getNgModuleDef (core.mjs:1130) at recurse (core.mjs:22110) at recurse (core.mjs:22121) at registerNgModuleType (core.mjs:22106) at new NgModuleFactory (core.mjs:22232) at compileNgModuleFactoryPOST_R3 (core.mjs:26275) at PlatformRef.bootstrapModule (core.mjs:26528) at Module.14720 (main.ts:51) at webpack_require (bootstrap:19) at webpack_exec (request.model.ts:135) getNgModuleDef @ core.mjs:1130 recurse @ core.mjs:22110 recurse @ core.mjs:22121 registerNgModuleType @ core.mjs:22106 NgModuleFactory @ core.mjs:22232 compileNgModuleFactoryPOST_R3 @ core.mjs:26275 bootstrapModule @ core.mjs:26528 14720 @ main.ts:51 webpack_require @ bootstrap:19 webpack_exec @ request.model.ts:135 (anonymous) @ request.model.ts:135 __webpack_require__.O @ chunk loaded:23 (anonymous) @ request.model.ts:135 webpackJsonpCallback @ jsonp chunk loading:71 (anonymous) @ main.js:2

The application does not run.

Expected behavior

The program should run without such an error.

Error related package.json modules: "@ngneat/hot-toast": "^3.4.3" "@ngneat/overview": "^3.0.0",

Modules that run without errors: "@ngneat/hot-toast": "^3.4.3" "@ngneat/overview": "^2.1.0",

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

## Environment

Angular version:    "@angular/cli": "^13.0.2",

Browser:

  • [ x] Chrome (desktop) version 95.0.4638.54 (Official Build) (64-bit)
  • [ ] Chrome (Android) version XX
  • [ ] Chrome (iOS) version XX
  • [ x] Firefox version 94
  • [ ] Safari (desktop) version XX
  • [ ] Safari (iOS) version XX
  • [ ] IE version XX
  • [ ] Edge version XX

For Tooling issues:

  • Node version: XX <!-- run node --version --> Node v16.13.0
  • Platform: Kernel Name| Linux Kernel Release| 5.4.0-90-generic Kernel Version| #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 Host Name| scscwrk Machine Hardware Name| x86_64 OS| GNU/Linux Code Name| Linux Processor| x86_64 Platform| x86_64

Others:

NetanelBasal commented 3 years ago

https://github.com/ngneat/hot-toast/pull/93

st-clair-clarke commented 3 years ago

I am using angular 13. How do I switch to the moder APF?