ngneat / overview

🤖 A collection of tools to make your Angular views more modular, scalable, and maintainable
MIT License
121 stars 7 forks source link

Unable to build project after 4.0.0 version release #15

Closed InYourHead closed 1 year ago

InYourHead commented 1 year ago

My issue below:

Before this update my package.json look like this:

{
  "name": "myapp-lib",
  "version": "0.0.20",
  "peerDependencies": {
    [...]
    "@angular/core": "^13.1.0",
    "@angular/forms": "^13.1.0",
    [..]
    "@ngneat/helipopper": "^5.1.4",
    "@ngneat/overview": "^3.0.4",
  },
  "dependencies": {
    [...]
  },
 [..]
}

with dependant app:

{
  "name": "myapp",
  "version": "0.0.20",
  "scripts": {
   [...]
  },
  "engines": {
    "node": ">=16.13.2",
    "npm": ">=8.1.2"
  },
  "private": true,
  "dependencies": {
   [...]
    "myapp-lib" : "0.0.20",
    [..]
  },
  "devDependencies": {
    "@angular-devkit/build-angular": "^13.1.3",
    "@angular/cli": "^13.1.3",
    "@angular/compiler-cli": "^13.1.0",
    [..],
    "typescript": "~4.5.2"
  }
}

After this update @ngneat/overview is resolved as version 4.x.x, no matter do I set here:

  "@ngneat/overview": "<4.0.0",

or:

  "@ngneat/overview": "3.x.x",

Given error occurs. Do you know how could I fix this issue?

Originally posted by @InYourHead in https://github.com/ngneat/overview/issues/14#issuecomment-1400340064

InYourHead commented 1 year ago

Error during build:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: myapp@0.0.0
npm ERR! Found: @angular/core@13.3.12
npm ERR! node_modules/@angular/core
npm ERR!   @angular/core@"^13.1.0" from the root project
npm ERR!   peer @angular/core@"^13.1.0" from myapp-lib@0.0.0-release-candidate-0-27.3
npm ERR!   node_modules/myapp-lib
npm ERR!     myapp-lib@"0.0.0-release-candidate-0-27.3" from the root project
npm ERR!   14 more (@angular-material-extensions/password-strength, ...)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @angular/core@">=14" from @ngneat/overview@4.0.0
npm ERR! node_modules/@ngneat/overview
npm ERR!   peer @ngneat/overview@">=3.0.0" from @ngneat/helipopper@5.1.4
npm ERR!   node_modules/@ngneat/helipopper
npm ERR!     peer @ngneat/helipopper@"^5.1.4" from myapp-lib@0.0.0-release-candidate-0-27.3
npm ERR!     node_modules/myapp-lib
npm ERR!       myapp-lib@"0.0.0-release-candidate-0-27.3" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /tmp/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /tmp/.npm/_logs/2023-01-23T10_02_29_721Z-debug-0.log
InYourHead commented 1 year ago

I tried already to set strict version of peer dependency as:

"@ngneat/overview": "3.0.4",

it didn't work.

InYourHead commented 1 year ago

I think, that this error occurs, because in @ngneat/helipopper package.json there is:

"name": "@ngneat/helipopper",
  "version": "5.1.4",
  "description": "A Powerful Tooltip and Popover for Angular Applications",
  "dependencies": {
    "tippy.js": "6.3.7",
    "tslib": "2.3.1"
  },
  "peerDependencies": {
    "@angular/core": ">=13.0.0",
    "@ngneat/overview": ">=3.0.0" <-- install version higher than 3.0.0
  },

Which install newest version 4.0.0, and conflict occurs.

shaharkazaz commented 1 year ago

@InYourHead I think Helipopper is indeed the issue, someone opened a related issue. I released Helipopper v5.1.5, try it.

InYourHead commented 1 year ago

It works now, thanks!