search

ngneat / reactive-forms

(Angular Reactive) Forms with Benefits 😉
https://www.netbasal.com
611 stars 56 forks source link

fix: wrong usage of Control generic type in FormArray for FormBuilder… #138

Closed jogelin closed 2 years ago

jogelin commented 2 years ago

… and for ValuesOf

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ x ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #137

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

jogelin commented 2 years ago

@NetanelBasal I forgot to say that we are working with v3.1.4 because we are not yet compatible with angular 13. This is the reason why we are doing this migration. Would it be possible to also make a release in v3 too? Or the v4 is also compatible with angular v12 (didn't try)?

NetanelBasal commented 2 years ago

I've created a v12 branch. You should checkout and merge all the relevant changes to this branch. Then, I'll make a release for this.

jogelin commented 2 years ago

I've created a v12 branch. You should checkout and merge all the relevant changes to this branch. Then, I'll make a release for this.

I tested with the v4 and it seems backward compatible with angular v12 so you can just make a v4 release ;) Waiting for it :p

NetanelBasal commented 2 years ago

It's not, it's Ivy distribution.

NetanelBasal commented 2 years ago

I have already released it.

jogelin commented 2 years ago

It's not, it's Ivy distribution.

correct..this is because I am using Ivy already then ;)

jogelin commented 2 years ago

I have already released it.

it works on our side, thanks ;)