Bugfix/undefined properties - Githubissues

ngneat / svg-icon

👻 A lightweight library that makes it easier to use SVG icons in your Angular Application

https://netbasal.com

MIT License

260 stars 35 forks source link

Bugfix/undefined properties #133

Closed naaajii closed 1 year ago

naaajii commented 1 year ago

PR Checklist

Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: CONTRIBUTING.md#commit
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #130

currently it lets components properties such as height, width and color to have falsy values in styling.

What is the new behavior?

it doesn't update the properties unless the property isn't falsy & keeps last valid property.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

stackblitz[bot] commented 1 year ago

Run & review this pull request in StackBlitz Codeflow.