ngneat / svg-icon

👻 A lightweight library that makes it easier to use SVG icons in your Angular Application
https://netbasal.com
MIT License
257 stars 35 forks source link

@ngneat/svg-generator throws error and cannot find module 'svgo' #136

Open var-bin opened 1 year ago

var-bin commented 1 year ago

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior

After following the installation steps from the README.md, I started using @ngneat/svg-generator via npm script command"svg": "svg-generator". I faced the following error (attached screenshot) in the terminal.

22-35-54-jb8xr

After installing svgo as a devDependency, the issue has gone

Expected behavior

No issues during the process of using @ngneat/svg-generator. svgo installs within the package

Minimal reproduction of the problem with instructions

Generate a new Angular application. Run the following commands:

The previous commands added the following dependencies to the package.json

{
  "dependencies": {
    "@ngneat/svg-icon": "^7.0.0",
  },
  "devDependencies": {
    "@ngneat/svg-generator": "^7.0.0",
  }
}

What is the motivation / use case for changing the behavior?

It will be great not to face the issue and get all the dependencies within the package (i.e. npm i | yarn add).

Environment


Angular version: 16.1.0


Browser:
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX

For Tooling issues:
- Node version: 16.20.1
- Platform: Mac

Others:
- Package manager: yarn
- yarn version: 1.22.0

tbertran commented 1 year ago

Any update on this? I'm seeing the same error.

NetanelBasal commented 10 months ago

Is this still an issue?

Gian-Marco-27 commented 9 months ago

any news?