ngneat / svg-icon

👻 A lightweight library that makes it easier to use SVG icons in your Angular Application
https://netbasal.com
MIT License
260 stars 35 forks source link

Type signature errors with `bootstrapModule()` - documentation refers to out of date `bootstrapApplication()` #139

Closed jziggas closed 11 months ago

jziggas commented 1 year ago

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[ ] Feature request
[x] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior

The current documentation demonstrates package setup using bootstrapApplication(...).

Expected behavior

The documentation demonstrates package setup using the default platformBrowserDynamic().bootstrapModule(...) code generated in a new Angular 15+ project.

Minimal reproduction of the problem with instructions

Create a new angular app using ng cli 15+ to see a main.ts along the lines of:

if (environment.production) {
  enableProdMode();
}

platformBrowserDynamic()
  .bootstrapModule(AppModule)
  .catch((err) => console.error(err));

What is the motivation / use case for changing the behavior?

Type signature errors prevent the use of svg-icon with bootstrapModule.

image image

Environment

Angular core: ^15.2.9

NetanelBasal commented 11 months ago
Screenshot 2023-11-25 at 19 49 33

Works for me