ngneat / svg-icon

👻 A lightweight library that makes it easier to use SVG icons in your Angular Application
https://netbasal.com
MIT License
257 stars 35 forks source link

fix(svg-generator): add ts-nocheck on generated files #140

Closed shaharkazaz closed 1 year ago

shaharkazaz commented 1 year ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

stackblitz[bot] commented 1 year ago

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

miki10194 commented 9 months ago

is it possible to avoid add this code? @shaharkazaz

shaharkazaz commented 9 months ago

@miki10194 can you share why?

miki10194 commented 9 months ago

@shaharkazaz Error:(1, 1) ESLint: Do not use "@ts-nocheck" because it alters compilation errors. (@typescript-eslint/ban-ts-comment) this problem during commit :) In this case I have to remove it manually

shaharkazaz commented 9 months ago

@miki10194 Generally speaking I think you should exclude the generated files from linting as they are auto-generated.

The reason we've added this comment is to reduce redundant work as it's guaranteed that there are no semantic errors there.