ngneat / svg-icon

👻 A lightweight library that makes it easier to use SVG icons in your Angular Application
https://netbasal.com
MIT License
260 stars 35 forks source link

fix(svg-generator): add kebab-case transform to type generator (#143) #144

Closed mokipedia closed 11 months ago

mokipedia commented 11 months ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

icons with _ in name generate a missmatch between key and type, as keys are converted to kebab-case

Issue Number: #143

What is the new behavior?

as discussed in #143: types are now also generated as kebab-case

Does this PR introduce a breaking change?

[ ] Yes
[X] No
stackblitz[bot] commented 11 months ago

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

NetanelBasal commented 11 months ago

@mokipedia tests are failing in CI

mokipedia commented 11 months ago

tests should be green now, my bad.