Add missing icon feature to render icon when it is not found in registry - Githubissues

ngneat / svg-icon

👻 A lightweight library that makes it easier to use SVG icons in your Angular Application

https://netbasal.com

MIT License

257 stars 35 forks source link

Add missing icon feature to render icon when it is not found in registry #42

Closed zgabievi closed 3 years ago

zgabievi commented 3 years ago

PR Checklist

Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: CONTRIBUTING.md#commit
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Now if icon is not found in the registry, you don't get feedback or any visual information.

Issue Number: N/A

What is the new behavior?

You can defined missingIcon in configuration and you will get default icon, if the one you requested in your component was not found.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information