search

ngneat / until-destroy

🦊 RxJS operator that unsubscribe from observables on destroy
https://netbasal.com/
MIT License
1.74k stars 100 forks source link

9.1.0 raises "No provider for SubjectUnsubscribedChecker" #193

Closed devfservant closed 2 years ago

devfservant commented 2 years ago

When developing locally, I have some NullInjectorError errors:

image

They were not there before upgrading to 9.1.0. It is still there with 9.1.1.

Are they as expected? Could it come from the use of createEffect from @ngrx/effects?

I have a quite big codebase so it is a bit hard to precisely isolate where does the issue come from.

Thank you

NetanelBasal commented 2 years ago

@arturovt I would revert this change for now and consider replacing it with an eslint rule if we can't cover all the cases.

arturovt commented 2 years ago

@NetanelBasal alright, that makes sense.

arturovt commented 2 years ago

I've reverted the change. Will work on the ESLint rule.

devfservant commented 2 years ago

Hello, I've seen that the revert has been reverted back, is it as expected? Thank you