search

ngneat / until-destroy

🦊 RxJS operator that unsubscribe from observables on destroy
https://netbasal.com/
MIT License
1.74k stars 100 forks source link

How to use until-destroy-migration? #215

Closed ivanyurchenko1 closed 1 year ago

ivanyurchenko1 commented 1 year ago

Hello. I'm trying to apply the migration as mentioned in the readme.

I added the package with this command: npm i --save-dev @ngneat/until-destroy-migration

And now I'm trying to do npx @ngneat/until-destroy-migration --base my/path which doesn't do anything at all. No errors, no changes. I changed path to mine, also tried to run without path, as well as without --base prefix. Nothing is happening.

arturovt commented 1 year ago

Can you provide a minimal reproducible example?

ivanyurchenko1 commented 1 year ago

Sure. Create any project, let's say https://stackblitz.com/edit/angular-playground

Download it, do npm i --save-dev @ngneat/until-destroy-migration and try to apply the npx @ngneat/until-destroy-migration --base my/path

The same happens - nothing is changed. No errors or anything.

image

arturovt commented 1 year ago

But what are you expecting to be done? The migration script is used to move the old view engine API to the new format. The view engine required ngOnDestroy to be declared on the class which is not required in Ivy.

arturovt commented 1 year ago

Closing as not an issue.