ngneat / until-destroy

🦊 RxJS operator that unsubscribe from observables on destroy
https://netbasal.com/
MIT License
1.74k stars 100 forks source link

fix: support non experimental decorators #230

Closed yharaskrik closed 1 year ago

yharaskrik commented 1 year ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

With TS 5.0 and Angular 16 the @UntilDestroy decorator is not compatible with disabling experimentalDecorators

Issue Number: #229

What is the new behavior?

Will not work when experimental flag is disabled.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

stackblitz[bot] commented 1 year ago

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

arturovt commented 1 year ago

Thanks for the fix! Can you please update the commit message and change build to fix?

yharaskrik commented 1 year ago

Thanks for the fix! Can you please update the commit message and change build to fix?

Done and done!

arturovt commented 1 year ago

I will do a pre-release because Angular 16 has not been released yet. I will do a major release to align with Angular's major release.

arturovt commented 1 year ago

I will do a pre-release because Angular 16 has not been released yet. I will do a major release to align with Angular's major release.

@ngneat/until-destroy@10.0.0-beta.0

yharaskrik commented 1 year ago

I will do a pre-release because Angular 16 has not been released yet. I will do a major release to align with Angular's major release.

Sounds good! I'll give it a shot today!

simfyz commented 1 year ago

@arturovt is there any update on the release? Angular 16 is already live.

arturovt commented 1 year ago

@arturovt is there any update on the release? Angular 16 is already live.

I've published 10.0.0