search

ngneat / until-destroy

🦊 RxJS operator that unsubscribe from observables on destroy
https://netbasal.com/
MIT License
1.74k stars 100 forks source link

Error when using Target 2022 - Similar issue link provided #246

Open AngularTx opened 6 months ago

AngularTx commented 6 months ago

Hi There ,

I just migrated my angular codebase to 15 via NX . The application was running firn earlier without ant errors. Now after the migration we see some errors in console related to subscribe.

Also found the below issues reported that using UntilDestroy() causes the issue. I would like to know if this issue is really from or changing target to 2020 works fine with no errors in console.

https://github.com/angular/components/issues/26335

arturovt commented 6 months ago

This issue will be closed soon if a reproducible example is not provided. There is no justification for making assertions based solely on text; without a concrete problem visible, we cannot address it effectively. Additionally, we will not be making any changes for Angular 15 because: 1) We are significantly ahead of this version, and 2) Its LTS support ends in one month.

AngularTx commented 6 months ago

https://github.com/angular/components/issues/26335 Here the details are given.

They closed the issue there stating that its due to UntilDestroyed . So I think we have a good example in that link.

arturovt commented 6 months ago

I am unclear about the specific issue and its relation to the material.

AngularTx commented 6 months ago

@UntilDestroy({ checkProperties: true })

when this is used , seems like we get the error in console.

when target is 2022 set for compiler option.

Option was to make it 2020, or get rid of this @UntilDestroy(). But doing that we are losing all of the functionality of ngneat here.

When we make it 2020, the code runs with no errors.

arturovt commented 6 months ago

Could you please provide a minimal reproducible example so that we can proceed with resolving the issue?

AngularTx commented 6 months ago

https://stackblitz.com/edit/angular-ivy-jwttzg?file=tsconfig.json https://angular-ivy-jwttzg.stackblitz.io

arturovt commented 6 months ago

However, this is Angular 10, and the library version is 7.3.2, which significantly lags behind in terms of all the fixes it has received since then. What are we expected to fix under these circumstances?

AngularTx commented 6 months ago

What version is expected for angular 15 and above for ngneat ?

arturovt commented 6 months ago

@ngneat/until-destroy@9.2.3 and above.