search

ngnigel99 / pe

0 stars 0 forks source link

Lesson link not validated #11

Open ngnigel99 opened 2 years ago

ngnigel99 commented 2 years ago

Nonsense meeting url:

image.png

Since there's no check for url, the following occurs

image.png

nus-se-script commented 2 years ago

Team's Response

We decided to not validate meeting link and this is a design decision. From an implementation perspective, checking whether a link is valid or not requires a lot of time resources and it would make our program unnecessarily slow. Furthermore, there exists non-standard URL format. To add on this, our program actually validate whether the input link is of www or http, and they will be automatically replace with https. This implementation has two benefits such as portability and security.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Agreed that it's out of scope to test the validity of zoom links per se, however following your example in the DG,

Test case: add lesson CS2113T tutorial -d wed -s 11:00 -e 12:00 -l zoom.us/a19b3jkdjk93

There are other ways to check valid links - for instance, the existence of zoom.us, which would not accept nonsense input such as l.

Additionally, as there's no way to update a lesson should the user accidentally paste the wrong link by typing too fast, a simple check would do the trick to validate input.

image.png

:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.FunctionalityBug]

Reason for disagreement: Lack of input validation, irreversible addition of lesson links.

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: Unable to update the lesson should the user add the wrong link, so the user has to list lesson, delete lesson, add lesson, which takes a lot more work than creating a shortcut on the desktop, making the app inconvenient to use.