search

ngnigel99 / pe

0 stars 0 forks source link

Unconventional formatting of class diagram (DG) #18

Open ngnigel99 opened 3 years ago

ngnigel99 commented 3 years ago

Correct me if I'm wrong, but perhaps these boxes for command and parser (at least) could be removed? image.png

The classes already have 'command' or 'parser' e.g. 'XYZCommand' , and there's already an inheritance arrow for command so I don't think it's necessary to box it up.

nus-se-bot commented 3 years ago

Team's Response

We believe the boxes will improve the clarity of our diagram.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: image.png

Insufficient explanation on improving clarity. What information is lost if i do this:

image.png

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: [replace this with your explanation]