Open ngnigel99 opened 2 years ago
While it is true that a
might not be a valid module from NUSMods, however, our current implementation is more efficient. Consider the two scenarios:
1. User input module -> check user list -> exist or not
2. User input module -> check NUSMods -> check list -> exist or not
Note: Checking NUSMods is a relatively expensive operation
We choose to only check the module in the user list to improve our program efficiency (i.e., to avoid scenario 2). Also, our current error message is technically correct as well.
Team chose [response.Rejected
]
Reason for disagreement: [replace this with your explanation]
this is a NFE, rather than a not found