search

ngnigel99 / pe

0 stars 0 forks source link

Able to add lesson that ends immediately #9

Open ngnigel99 opened 2 years ago

ngnigel99 commented 2 years ago

image.png

Able to add lesson that has start time = end time

soc-se-bot commented 2 years ago

Team's Response

This is an intentional design decision adopted by our team to improve flexibility of our app. This approach is also adopted by Google Calendar (e.g., user can add an event that start and end at the same time). From a functionality perspective, this is surprisingly useful for some user. For instance, user can add something similar to a deadline as it has the same start and end time.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Agree with your reasoning fully.

However, do note that my bug refers to Lesson, and not Task - you mention deadlines - I don't think that deadlines are a valid lesson in NUS, and it doesn't make much sense semantically.

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Medium]

Reason for disagreement: Considering context of the app, lessons are well, for lessons

image.png

If the user wanted to enter a deadline, they could use add task as the app is operated on a weekly basis.

image.png

Even for deadlines, it wouldn't make much sense to consider an assignment submission as a lesson. Perhaps a more reasonable implementation would be to add a task with a date in that sense.