search

ngnrsaa / qflex

Flexible Quantum Circuit Simulator (qFlex) implements an efficient tensor network, CPU-based simulator of large quantum circuits.
Apache License 2.0
96 stars 24 forks source link

Prevent direct push to 'master' branch #138

Closed 95-martin-orion closed 4 years ago

95-martin-orion commented 4 years ago

To make keep the repository formatted and bug-free, all changes to the master branch should be submitted as pull requests. This can be enforced by disabling direct pushes to master.

This change can only be performed by an owner of the repository.

alexandrupaler commented 4 years ago

Did I accidentally push to the master instead of the cirq_if branch?

s-mandra commented 4 years ago

Sounds good. I'll do that after dinner :)

95-martin-orion commented 4 years ago

Did I accidentally push to the master instead of the cirq_if branch?

No, this is just a long-standing concern of mine. I've had several near misses myself :/

s-mandra commented 4 years ago

Done. Let me know if you can still push on master.

95-martin-orion commented 4 years ago

Done. Let me know if you can still push on master.

Verified that pushes to master are rejected. Thanks!

95-martin-orion commented 4 years ago

Seems that merging is now blocked for non-owners - seen on #140:

Merging is blocked
The base branch restricts merging to authorized users.

This is probably what we want, but the set of "authorized users" should be expanded (if only to speed up the review process).

s-mandra commented 4 years ago

No probs, I'm adding you and @alexandrupaler.

s-mandra commented 4 years ago

Done.