Final checks before open-source

[95-martin-orion]

In the last ${TBD} hours prior to publicizing this repository, we should lock down code changes and run through the following checks on at least two different machines:

• All documented examples run as written (no additional config required)
  • This includes one run each of bristlecone 48 and 70 in both python and C++.
• All tests pass with reasonable (i.e. < 30s) runtime
• All of the above work for all installation modes:
  • Docker
  • rootless_container
  • autoconf
• check_format doesn't highlight any issues (make sure that the latest YAPF version is used for this!)

Additionally, we should ensure that all incoming changes (regardless of source) pass through the review process before being pushed to master:

• Formatting and tests should be checked automatically (see #7)
  • This will require post-release changes.
• At least one member of the qFlex team should sign off on the change (see #138)
• New contributors should not be able to create branches in the qFlex repo (these PRs should be sent from project forks instead)

Finally, a general "repository cleanliness" sweep should be run:

• Verified-obsolete branches should be deleted

[benjaminvillalonga]

Not sure if it belongs here, but we should get contributions right on the file headers. Only the people (very) originally involved appear, and many missing: Orion, Alan, Alexandru, etc.

[95-martin-orion]

We should get contributions right on the file headers.

Agreed. Given that this is now a decently long list and CONTRIBUTORS.md (#136) documents it, should we do like Cirq and attribute the work to "The qFlex Developers"?

[s-mandra]

We should get contributions right on the file headers.

Agreed. Given that this is now a decently long list and CONTRIBUTORS.md (#136) documents it, should we do like Cirq and attribute the work to "The qFlex Developers"?

Here there is a NASA related issue. We cannot change the headers for those files where I put the NASA copyright (which are the original [or almost the original] qFlex files). This accounts to:

contraction_utils.{cpp,h}
evaluate_circuit.{cpp,h}
read_circuit.{cpp,h}
tensor.{cpp,h}

For the other files, I'm ok to change the headers.

[s-mandra]

What I can do, it's to add a field contributors in each of the NASA files that says:

@contributors: The qFlex Developers

[s-mandra]

Create #156 to discuss about headers/contributions.

[s-mandra]

Remove dead branches #157.

[95-martin-orion]

Update from 9:30 meeting: once all required PRs are submitted (currently includes #155, #140, and #154) I will send out a "PR freeze" notice. At this point, we will run the required checks:

• @alankao64 and @s-mandra will handle the top group of checks (tests, examples, and installation work as expected)
• @s-mandra will run check_format against the repo
• @s-mandra will verify that users not in CONTRIBUTORS.md cannot create new branches
• Everyone is responsible for cleaning up their own obsolete branches.

Once all checks are complete and an hour has passed since the start of the PR-freeze, @s-mandra will officially open-source qFlex :)

[95-martin-orion]

All checks are complete. qFlex is ready for open-source!

[s-mandra]

Good to go.