search

ngnrsaa / qflex

Flexible Quantum Circuit Simulator (qFlex) implements an efficient tensor network, CPU-based simulator of large quantum circuits.
Apache License 2.0
97 stars 24 forks source link

remove pybind11 submodule #172

Closed alexandrupaler closed 4 years ago

alexandrupaler commented 4 years ago

Solves issue #166 by removing the submodule and keeping pybind installed through python package manager

The Makefiles had duplicate paths to pybind headers

95-martin-orion commented 4 years ago

@alexandrupaler, will #171 also be resolved by this change? Since the user would no longer need to build pybind11 using icpc...

alexandrupaler commented 4 years ago

no, this just removes a duplicate source of header files

alexandrupaler commented 4 years ago

i do not have icpc, but am curious if the flag i mentioned in #171 solves the issue