In the long term, we should change these to try-catch blocks with explicit failure expectations, e.g.:
// test case
try {
should_fail();
FAIL() << "Expected should_fail to fail, but it didn't.";
} catch (string msg) {
EXPECT_THAT(msg, HasSubstr("expected message"));
}
That way we can ensure that the test is actually hitting the expected failure, and not some other exception.
In the long term, we should change these to try-catch blocks with explicit failure expectations, e.g.:
That way we can ensure that the test is actually hitting the expected failure, and not some other exception.
Originally posted by @95-martin-orion in https://github.com/ngnrsaa/qflex/pull/110#issuecomment-543478708