Closed 95-martin-orion closed 5 years ago
Hi, I've merged my PRs into cpp_only
, and then merged them into your PR. PTAL to make sure I haven't broken it.
Everything looks good post-merge. Can you verify that the tests work on your end? I ran them with the usual FLAGS changes in both the root and tests/ Makefiles.
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from ReadCircuitTest
[ RUN ] ReadCircuitTest.NullCircuit
[ OK ] ReadCircuitTest.NullCircuit (11 ms)
[----------] 1 test from ReadCircuitTest (11 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (11 ms total)
[ PASSED ] 1 test.
Thanks! This will make verifying that changes don't break things easier in the future.
Part of issue #3.
In order to run this locally, I followed these instructions:
CXX = icpc
withCXX = g++
FLAGS = -fopenmp -O3 -std=c++17 -march=native -I/usr/local/google/home/${USER}/intel/compilers_and_libraries_2019.3.199/linux/mkl/include -L/usr/local/google/home/${USER}/intel/compilers_and_libraries_2019.3.199/linux/mkl/lib/intel64 -lmkl_intel_ilp64 -lmkl_core -lmkl_gnu_thread -Wno-narrowing
export LD_LIBRARY_PATH="/usr/local/google/home/${USER}/intel/compilers_and_libraries_2019.3.199/linux/mkl/lib/intel64"